From: Jeff King <peff@peff.net>
Date: Thu, 22 Dec 2016 22:19:12 GMT
Subject: Re: [PATCH 4/2] t5615-alternate-env: double-quotes in file names do not work on Windows
Message-ID: <20161222221912.2q722cnrl2hnz6pi@sigill.intra.peff.net>
In-Reply-To: <54ba9cff-b6f7-7660-261f-393cd5181da6@kdbg.org>

On Thu, Dec 22, 2016 at 08:06:02PM +0100, Johannes Sixt wrote:

> Am 22.12.2016 um 07:13 schrieb Johannes Sixt:
> > Am 21.12.2016 um 23:42 schrieb Jeff King:
> > > Hmph. I explicitly avoided a colon in the filename so that it would run
> > > on MINGW. Is a double-quote also not allowed?
> > 
> > It is not allowed; that was my conclusion. But now that you ask, I'll
> > double-check.
> 
> Ok, the point is that I get this error:
> 
> mv: cannot move `one.git' to `"one.git'
> 
> I don't feel inclined to find out which of 'mv' or the Windows API or the
> NTFS driver prevents the double-quotes and come up with a work-around just
> to get the test to run in some form. Let's leave it at the !MINGW
> prerequisite.

Thank you for double-checking (and sorry if my initial question was
confusing; I somehow missed the mention of dq in your subject line, and
just read the message body).

Your patch seems like the best solution.

-Peff