From: Brandon Williams Date: Wed, 14 Dec 2016 18:00:56 GMT Subject: Re: [PATCH v9 4/5] http: create function to get curl allowed protocols Message-ID: <20161214180056.GB20063@google.com> In-Reply-To: <20161214160330.iqvwxshsgk4n2gm7@sigill.intra.peff.net> On 12/14, Jeff King wrote: > On Tue, Dec 13, 2016 at 05:40:36PM -0800, Brandon Williams wrote: > > > Move the creation of an allowed protocols whitelist to a helper > > function. > > This is "what" but not "why". You can figure it out if you see the next > patch, but it's often nice to make a brief mention, like: > > This will be useful when we need to compute the set of allowed > protocols differently for normal and redirect cases. Commit message writing is hard (at least for me :). I'll update the message to indicate the why. -- Brandon Williams