From: Brandon Williams <bmwill@google.com>
Date: Wed, 07 Dec 2016 22:41:55 GMT
Subject: Re: [PATCH 09/17] pathspec: always show mnemonic and name in unsupported_magic
Message-ID: <20161207224155.GF116201@google.com>
In-Reply-To: <CACsJy8CKY5wb+0KzpincHLiYwC0za9Wexo9QvNedcQTGc+ZRDw@mail.gmail.com>

On 12/07, Duy Nguyen wrote:
> On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams <bmwill@google.com> wrote:
> > @@ -413,10 +411,9 @@ void parse_pathspec(struct pathspec *pathspec,
> >         prefixlen = prefix ? strlen(prefix) : 0;
> >
> >         for (i = 0; i < n; i++) {
> > -               unsigned short_magic;
> >                 entry = argv[i];
> >
> > -               item[i].magic = prefix_pathspec(item + i, &short_magic,
> > +               item[i].magic = prefix_pathspec(item + i,
> >                                                 flags,
> >                                                 prefix, prefixlen, entry);
> 
> The final output looks a bit ...um.. strangely tall, with the first
> two lines that have one argument each, then the last line comes with
> three arguments. Maybe put 'flags' in the same line as 'item + i'?

Yep you're right, it does look a bit funny.

-- 
Brandon Williams