From: Brandon Williams <bmwill@google.com>
Date: Mon, 05 Dec 2016 19:29:18 GMT
Subject: Re: [RFC PATCHv2 17/17] checkout: add config option to recurse into submodules by default
Message-ID: <20161205192918.GB68588@google.com>
In-Reply-To: <20161203003022.29797-18-sbeller@google.com>

On 12/02, Stefan Beller wrote:
> +test_expect_success 'option checkout.recurseSubmodules updates submodule' '
> +	test_config checkout.recurseSubmodules 1 &&
> +	git checkout base &&
> +	git checkout -b advanced-base &&
> +	git -C submodule commit --allow-empty -m "empty commit" &&
> +	git add submodule &&
> +	git commit -m "advance submodule" &&
> +	git checkout base &&
> +	git diff-files --quiet &&
> +	git diff-index --quiet --cached base &&
> +	git checkout advanced-base &&
> +	git diff-files --quiet &&
> +	git diff-index --quiet --cached advanced-base &&
> +	git checkout --recurse-submodules base
> +'
> +

This test doesn't look like it looks into the submodule to see if the
submodule has indeed changed.  Unless diff-index and diff-files recurse
into the submodules?
-- 
Brandon Williams