From: Jeff King Date: Sat, 03 Dec 2016 05:24:22 GMT Subject: Re: [PATCH 4/4] shallow.c: remove useless test Message-ID: <20161203052422.hhaj3idboo6r6dz5@sigill.intra.peff.net> In-Reply-To: <1480710664-26290-4-git-send-email-rv@rasmusvillemoes.dk> On Fri, Dec 02, 2016 at 09:31:04PM +0100, Rasmus Villemoes wrote: > It seems to be odd to do x=y if x==y. Maybe there's a bug somewhere near > this, but as is this is somewhat confusing. Yeah, this code is definitely wrong, but I'm not sure what it's trying to do. This is the first time I've looked at it. -Peff