From: Jeff King <peff@peff.net>
Date: Thu, 01 Dec 2016 18:52:08 GMT
Subject: Re: [PATCH v6 5/6] grep: enable recurse-submodules to work on <tree> objects
Message-ID: <20161201185208.5yikalvlnft5wwqk@sigill.intra.peff.net>
In-Reply-To: <20161201175107.GB51406@google.com>

On Thu, Dec 01, 2016 at 09:51:07AM -0800, Brandon Williams wrote:

> On 12/01, Johannes Sixt wrote:
> > Am 01.12.2016 um 02:28 schrieb Brandon Williams:
> > >+	git init "su:b" &&
> > 
> > Don't do that. Colons in file names won't work on Windows.
> > 
> > -- Hannes
> > 
> 
> This test is needed to see if the code still works with filenames that
> contain colons.  Is there a way to mark the test to not run on windows?

Junio suggested !MINGW, which seems sensible. Earlier I mentioned doing
the whole thing in-index, but I think that might get tricky because we
try to find the submodule as ".git/modules/<path>". So it probably isn't
worth the trouble.

-Peff