From: Brandon Williams <bmwill@google.com>
Date: Mon, 28 Nov 2016 18:03:58 GMT
Subject: Re: [PATCH 31/35] pathspec: allow querying for attributes
Message-ID: <20161128180358.GB150448@google.com>
In-Reply-To: <20161110203428.30512-32-sbeller@google.com>

On 11/10, Stefan Beller wrote:
> +static void parse_pathspec_attr_match(struct pathspec_item *item, const char *value)
> +{
>
> [...]
>
> +	if (!item->attr_check)
> +		git_attr_check_initv(&item->attr_check, attrs.argv);
> +	else
> +		die(_("Only one 'attr:' specification is allowed."));
> +
> +	argv_array_clear(&attrs);
> +	string_list_clear(&list, 0);
> +	return;
> +}

Unnecessary return statement, maybe you want to remove it?

-- 
Brandon Williams