From: Brandon Williams Date: Thu, 17 Nov 2016 19:06:22 GMT Subject: Re: [PATCH v2 0/2] bug fix with push --dry-run and submodules Message-ID: <20161117190622.GL66382@google.com> In-Reply-To: On 11/17, Stefan Beller wrote: > On Thu, Nov 17, 2016 at 10:46 AM, Brandon Williams wrote: > > v2 of this series is just a small cleanup of removing a nested sub-shell from a > > test and rebasing on the latest version of > > 'origin/hv/submodule-not-yet-pushed-fix' > > > > As stated above this series is based on 'origin/hv/submodule-not-yet-pushed-fix' > > an interdiff to v1 would be nice :) > > Now t5531 is inconsistent in style, > how much time would you estimate to add a commit to refactor > that test to follow the style with excessive use of -C for > all the other tests and avoiding subshells there, too? I didn't change to an excessive use of the -C option, but rather eliminated the nested-subshell and instead cd'ed to the required directories in the subshell. Excessive use of -C seemed to greatly reduce the readability of the test (at least it did to me). -- Brandon Williams