From: Brandon Williams Date: Tue, 15 Nov 2016 23:34:04 GMT Subject: Re: [PATCH 07/16] update submodules: introduce submodule_is_interesting Message-ID: <20161115233404.GD66382@google.com> In-Reply-To: <20161115230651.23953-8-sbeller@google.com> On 11/15, Stefan Beller wrote: > +/** > + * When updating the working tree, do we need to check if the submodule needs > + * updating. We do not require a check if we are already sure that the > + * submodule doesn't need updating, e.g. when we are not interested in submodules > + * or the submodule is marked uninteresting by being not initialized. > + */ The first sentence seems a bit awkward. It seems like its worded as a question, maybe drop the 'do'? -- Brandon Williams