From: Stefan Beller Date: Thu, 10 Nov 2016 20:33:57 GMT Subject: [PATCH 04/35] attr.c: explain the lack of attr-name syntax check in parse_attr() Message-ID: <20161110203428.30512-5-sbeller@google.com> In-Reply-To: <20161110203428.30512-1-sbeller@google.com> From: Junio C Hamano Signed-off-by: Junio C Hamano Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano --- attr.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/attr.c b/attr.c index 4ae7801..05db667 100644 --- a/attr.c +++ b/attr.c @@ -183,6 +183,12 @@ static const char *parse_attr(const char *src, int lineno, const char *cp, return NULL; } } else { + /* + * As this function is always called twice, once with + * e == NULL in the first pass and then e != NULL in + * the second pass, no need for invalid_attr_name() + * check here. + */ if (*cp == '-' || *cp == '!') { e->setto = (*cp == '-') ? ATTR__FALSE : ATTR__UNSET; cp++; -- 2.10.1.469.g00a8914