From: Brandon Williams <bmwill@google.com>
Date: Tue, 01 Nov 2016 17:24:43 GMT
Subject: Re: [PATCH v2 1/6] submodules: add helper functions to determine presence of submodules
Message-ID: <20161101172443.GB13899@google.com>
In-Reply-To: <xmqq7f8nqfqc.fsf@gitster.mtv.corp.google.com>

On 11/01, Junio C Hamano wrote:
> Stefan Beller <sbeller@google.com> writes:
> 
> Overall the suggestions from you in this review is good and please
> consider anything I did not mention I agree with you.  Thanks.
> 
> >> +extern int is_submodule_initialized(const char *path);
> >> +extern int is_submodule_checked_out(const char *path);
> >
> > no need to put extern for function names. (no other functions in this
> > header are extern. so local consistency maybe? I'd also claim that
> > all other extern functions in headers ought to be declared without
> > being extern)
> 
> Maybe I am old fashioned, but I'd feel better to see these with
> explicit "extern" in front (check the older header files like
> cache.h when you are in doubt what the project convention has been).

I wouldn't consider that old fashion as I'm fairly new to all this and
I also prefer the explicit "extern" :P

-- 
Brandon Williams