From: Jeff King <peff@peff.net>
Date: Wed, 05 Oct 2016 19:06:30 GMT
Subject: Re: [PATCH v2 1/5] check_connected: accept an env argument
Message-ID: <20161005190630.igp4bhdmpp2porc6@sigill.intra.peff.net>
In-Reply-To: <6ed4670d-6835-a45e-2842-cfe65b0e2981@gmail.com>

On Wed, Oct 05, 2016 at 09:01:57PM +0200, Jakub Narębski wrote:

> > diff --git a/connected.h b/connected.h
> > index afa48cc..4ca325f 100644
> > --- a/connected.h
> > +++ b/connected.h
> > @@ -33,6 +33,11 @@ struct check_connected_options {
> >  
> >  	/* If non-zero, show progress as we traverse the objects. */
> >  	int progress;
> > +
> > +	/*
> > +	 * Insert these variables into the environment of the child process.
> > +	 */
> > +	const char **env;
> >  };
> 
> Just a nitpick, but I wonder why one comment is in single-line form,
> and the other uses block-form with a single line.

I think I wrote something longer originally, and then shortened it
before sending.

I don't generally think it matters much for a case like this (if it were
in the middle of code, I think the shorter form is worth doing, but here
it's basically a header for this variable).

-Peff