From: Kevin Daudt <me@ikke.info>
Date: Wed, 28 Sep 2016 20:27:39 GMT
Subject: Re: [PATCH v4 1/2] t5100-mailinfo: replace common path prefix with variable
Message-ID: <20160928202739.GB22520@ikke.info>
In-Reply-To: <xmqqoa37ixmu.fsf@gitster.mtv.corp.google.com>

On Wed, Sep 28, 2016 at 01:21:13PM -0700, Junio C Hamano wrote:
> Kevin Daudt <me@ikke.info> writes:
> 
> > Many tests need to store data in a file, and repeat the same pattern to
> > refer to that path:
> >
> >     "$TEST_DIRECTORY"/t5100/
> >
> > Create a variable that contains this path, and use that instead.
> >
> > While we're making this change, make sure the quotes are not just around
> > the variable, but around the entire string to not give the impression
> > we want shell splitting to affect the other variables.
> 
> Wow.  I was half expecting that you'd say something like "1/2 plus
> the SQUASH is OK by me", but you went extra mile to do it right.
> 
> Impressed, and very much appreciated.
> 

You're What's Cooking mail mentioned you expected a reroll, so I guessed
that I could just fix this part as well.