From: Nguyễn Thái Ngọc Duy Date: Wed, 21 Sep 2016 11:29:39 GMT Subject: [PATCH v2 3/3] init: reuse original_git_dir in set_git_dir_init() Message-ID: <20160921112939.3444-4-pclouds@gmail.com> In-Reply-To: <20160921112939.3444-1-pclouds@gmail.com> Since original_git_dir is a copy of real_path(git_dir), let's reuse it and avoid calling real_path() more than necessary. The xstrdup() is removed too because original_git_dir is already a copy, and we're not going to free git_link in this code probably forever. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/init-db.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/init-db.c b/builtin/init-db.c index 0d5cc76..d70fc45 100644 --- a/builtin/init-db.c +++ b/builtin/init-db.c @@ -330,11 +330,11 @@ int set_git_dir_init(const char *git_dir, const char *real_git_dir, * make sure symlinks are resolved because we'll be * moving the target repo later on in separate_git_dir() */ - git_link = xstrdup(real_path(git_dir)); + git_link = original_git_dir; set_git_dir(real_path(real_git_dir)); } else { - set_git_dir(real_path(git_dir)); + set_git_dir(original_git_dir); git_link = NULL; } startup_info->have_repository = 1; -- 2.8.2.524.g6ff3d78