From: Jeff King Date: Tue, 13 Sep 2016 18:14:21 GMT Subject: Re: [PATCH] strbuf: use valid pointer in strbuf_remove() Message-ID: <20160913181420.ebsiscqk3sbc7axl@sigill.intra.peff.net> In-Reply-To: <408af1a3-6867-2ff5-c97f-3eb884412ad8@web.de> On Tue, Sep 13, 2016 at 06:40:22PM +0200, René Scharfe wrote: > The fourth argument of strbuf_splice() is passed to memcpy(3), which is > not supposed to handle NULL pointers. Let's be extra careful and use a > valid empty string instead. It even shortens the source code. :) Heh. Looks obviously correct and like a good thing to do. -Peff