From: Jeff King Date: Sat, 10 Sep 2016 06:00:13 GMT Subject: Re: [PATCH v4 1/3] tests: move test_lazy_prereq JGIT to test-lib.sh Message-ID: <20160910060012.rsnpgvk3mag4be5j@sigill.intra.peff.net> In-Reply-To: <20160910055119.GA11001@tb-raspi> On Sat, Sep 10, 2016 at 05:51:19AM +0000, Torsten Bögershausen wrote: > > +test_lazy_prereq JGIT ' > > + type jgit > > +' > > + > > Minor note: > Typically the stdout of `which` is suppressed like this: > > if ! type cvs >/dev/null 2>&1 But we don't want to suppress the output here; the test harness redirects the lazy_prereq output to /dev/null unless you specify "-v". And there is no need for "if", because what we care about is the exit code of the commands inside the lazy_prereq. -Peff