From: Jeff King <peff@peff.net>
Date: Thu, 08 Sep 2016 07:20:29 GMT
Subject: Re: [PATCH 2/3] diff_flush_patch_id: stop returning error result
Message-ID: <20160908072029.rwsa5b6zgwwe37ly@sigill.intra.peff.net>
In-Reply-To: <5c4276ad-19ed-1481-41cf-3d506ef9c7c6@ramsayjones.plus.com>

On Thu, Sep 08, 2016 at 01:51:05AM +0100, Ramsay Jones wrote:

> 
> 
> On 07/09/16 23:04, Jeff King wrote:
> > All of our errors come from diff_get_patch_id(), which has
> > exactly three error conditions. The first is an internal
> > assertion, which should be a die("BUG") in the first place.
> > 
> > The other two are caused by an inability to two diff blobs,
>                                            ^^^^^^^^^^^^^^^^^
> Huh? ... to diff two blobs?

Sorry. English my getting worse be to seems.

Will fix in a re-roll.

-Peff