From: Jonathan Nieder Date: Thu, 08 Sep 2016 01:50:40 GMT Subject: Re: [PATCH] connect: tighten check for unexpected early hang up (Re: [PATCH v3 2/2] connect: advertized capability is not a ref) Message-ID: <20160908015040.GF25016@google.com> In-Reply-To: <20160908014555.GD25016@google.com> Jonathan Nieder wrote: > Subject: connect: tighten check for unexpected early hang up [...] > @@ -131,7 +131,7 @@ struct ref **get_remote_heads(int in, char *src_buf, size_t src_len, > PACKET_READ_GENTLE_ON_EOF | > PACKET_READ_CHOMP_NEWLINE); > if (len < 0) > - die_initial_contact(got_at_least_one_head); > + die_initial_contact(first_line); This should say !first_line. I'll add tests if the patch seems like a good idea. Thanks, Jonathan