From: Torsten Bögershausen <tboegi@web.de>
Date: Tue, 30 Aug 2016 14:54:29 GMT
Subject: Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes
Message-ID: <20160830145429.GA11221@tb-raspi>
In-Reply-To: <4A177D61-AA25-415A-808D-B6BDA3BB5C47@gmail.com>


> 
> diff --git a/sha1_file.c b/sha1_file.c
> index d5e1121..759991e 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -1485,7 +1485,7 @@ int check_sha1_signature(const unsigned char *sha1, void *map,
>  
>  int git_open_noatime(const char *name)

Hm, should the function then be renamed into

git_open_noatime_cloexec()

>  {
> -	static int sha1_file_open_flag = O_NOATIME;
> +	static int sha1_file_open_flag = O_NOATIME | O_CLOEXEC;
>  
>  	for (;;) {
>  		int fd;
> 
> 
>