From: Jeff King <peff@peff.net>
Date: Wed, 24 Aug 2016 18:07:30 GMT
Subject: Re: [PATCH v2] for-each-ref: add %(upstream:gone) to mark missing refs
Message-ID: <20160824180730.mqlvhkthg4imd2vy@sigill.intra.peff.net>
In-Reply-To: <20160822173528.755-1-oystwa@gmail.com>

On Mon, Aug 22, 2016 at 07:35:28PM +0200, Øystein Walle wrote:

> git branch -vv will show "gone" next to a remote tracking branch if it
> does not exist. for-each-ref is suitable for parsing but had no way of
> showing this information.
> 
> This introduces "%(upstream:gone)" to display "gone" in the formatted
> output if the ref does not exist or an empty string otherwise, analogous
> to git branch -vv.
> 
> Signed-off-by: Øystein Walle <oystwa@gmail.com>
> ---
> I took the liberty of sending in a v2 on my own. Removed the last argument to
> stat_tracking_info() and used test_config instead of test_when_finished.

Whoops, your v2 spurred me to review, but I accidentally read and
responded to v1.

I think test_config may not be the right thing here, though; see my
other comments.

-Peff