From: Jeff King Date: Sat, 13 Aug 2016 12:24:51 GMT Subject: Re: [PATCH] commit: introduce set_merge_remote_desc() Message-ID: <20160813122451.vrqqjjpqicqtz2uj@sigill.intra.peff.net> In-Reply-To: <57AF0D8E.6040309@web.de> On Sat, Aug 13, 2016 at 02:07:42PM +0200, René Scharfe wrote: > So let's turn this dish into a full menu: > > commit: use xstrdup() in get_merge_parent() > commit: factor out set_merge_remote_desc() > merge-recursive: fix verbose output for multiple base trees > commit: use FLEX_ARRAY in struct merge_remote_desc Very nice. Four patches seems like a lot for such a small fix, but each one is so trivial and easy to understand, I think it's worth it. They all look good to me. -Peff