From: larsxschneider@gmail.com Date: Wed, 10 Aug 2016 13:04:09 GMT Subject: [PATCH v5 13/15] convert: make apply_filter() adhere to standard Git error handling Message-ID: <20160810130411.12419-14-larsxschneider@gmail.com> In-Reply-To: <20160810130411.12419-1-larsxschneider@gmail.com> From: Lars Schneider apply_filter() returns a boolean that tells the caller if it "did convert or did not convert". The variable `ret` was used throughout the function to track errors wheras `1` denoted success and `0` failure. This is unusual for the Git source where `0` denotes success. Rename the variable and flip its value to make the function easier readable for Git developers. Signed-off-by: Lars Schneider --- convert.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/convert.c b/convert.c index 522e2c5..bd17340 100644 --- a/convert.c +++ b/convert.c @@ -436,7 +436,7 @@ static int apply_filter(const char *path, const char *src, size_t len, int fd, * * (child --> cmd) --> us */ - int ret = 1; + int err = 0; struct strbuf nbuf = STRBUF_INIT; struct async async; struct filter_params params; @@ -463,22 +463,22 @@ static int apply_filter(const char *path, const char *src, size_t len, int fd, if (strbuf_read(&nbuf, async.out, len) < 0) { error("read from external filter '%s' failed", cmd); - ret = 0; + err = -1; } if (close(async.out)) { error("read from external filter '%s' failed", cmd); - ret = 0; + err = -1; } if (finish_async(&async)) { error("external filter '%s' failed", cmd); - ret = 0; + err = -1; } - if (ret) { + if (!err) { strbuf_swap(dst, &nbuf); } strbuf_release(&nbuf); - return ret; + return !err; } static struct convert_driver { -- 2.9.2