From: Jeff King <peff@peff.net>
Date: Sun, 07 Aug 2016 23:14:11 GMT
Subject: Re: [PATCH] use strbuf_add_unique_abbrev() for adding short hashes
Message-ID: <20160807231410.7cwclya7yykcg2cy@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.2.20.1608071051540.5786@virtualbox>

On Sun, Aug 07, 2016 at 10:53:34AM +0200, Johannes Schindelin wrote:

> On Sat, 6 Aug 2016, René Scharfe wrote:
> 
> > Call strbuf_add_unique_abbrev() to add abbreviated hashes to strbufs
> > instead of taking detours through find_unique_abbrev() and its static
> > buffer.  This is shorter and a bit more efficient.
> 
> And less error-prone.
> 
> It is also a thing I need to change in my upcoming rebase--helper patches:
> I had not known about this function.

Great. I added it several months ago to avoid some hairy allocation
code, so I am glad to see it finding new uses (both this patch and
potential new ones).

-Peff