From: Jeff King <peff@peff.net>
Date: Mon, 01 Aug 2016 16:49:29 GMT
Subject: Re: [PATCH] use strbuf_addstr() for adding constant strings to a strbuf
Message-ID: <20160801164929.ezalmutcrc3erc22@sigill.intra.peff.net>
In-Reply-To: <579CE597.4060009@web.de>

On Sat, Jul 30, 2016 at 07:36:23PM +0200, René Scharfe wrote:

> Replace uses of strbuf_addf() for adding strings with more lightweight
> strbuf_addstr() calls.
> 
> In http-push.c it becomes easier to see what's going on without having
> to verfiy that the definition of PROPFIND_ALL_REQUEST doesn't contain
> any format specifiers.

Nice. I care a lot less about whether "addf" or "addstr" is more
efficient. But the second point, that it makes the intent clearer, is a
big win.

-Peff