From: Jeff King <peff@peff.net>
Date: Thu, 14 Jul 2016 19:45:22 GMT
Subject: Re: [PATCH 2/4] receive-pack: implement advertising and receiving push options
Message-ID: <20160714194522.GA17798@sigill.intra.peff.net>
In-Reply-To: <xmqqfurcqbrw.fsf@gitster.mtv.corp.google.com>

On Thu, Jul 14, 2016 at 12:07:15PM -0700, Junio C Hamano wrote:

> > Although as you remarked in another email, this would not pose a problem for
> > the shell variable, so we could also drop it to allow multi line
> > options. will do.
> 
> One thing to note is that I do not think there is a guarantee that
> packet_buf[] is NUL-terminated, and when len == LAGE_PACKET_MAX, you
> do not have room to NUL-terminate it yourself.

packet_read() does NUL-terminate for you. It gets the extra bytes
because it doesn't store the 4-byte size in the output (whereas the
client does not ever send anything over LARGE_PACKET_MAX, _including_
those bytes, so we always have room to store its result in our
LARGE_PACKET_MAX buffer, plus the NUL, with 3 bytes to spare).

-Peff