From: Jeff King <peff@peff.net>
Date: Thu, 14 Jul 2016 18:41:46 GMT
Subject: Re: [PATCHv5 0/4] Push options
Message-ID: <20160714184146.GE16497@sigill.intra.peff.net>
In-Reply-To: <20160714173920.22001-1-sbeller@google.com>

On Thu, Jul 14, 2016 at 10:39:16AM -0700, Stefan Beller wrote:

> Jeff wrote:
> > Junio wrote:
> >> I think those extra knobs can come later.  If we are not going to
> >> limit with max_options in the end, however, wouldn't it be more
> >> natural for the initial iteration without any configuration not to
> >> have hard-coded max_options at all?
> >
> > Yeah, I am OK with adding restrictive knobs later as a separate topic.
> > As Stefan notes, upstream does not have the other knobs anyway, and IIRC
> > the push-options feature is not even enabled by default.
> 
> * now it actually is not a default. ;)

Hmm. So that is a downside for people who have implemented separate DoS
protection only in that upgrading git will open a new "hole" that they
need to plug. But that is their problem, not upstream git's.

-Peff