From: Nguyễn Thái Ngọc Duy Date: Tue, 05 Jul 2016 17:05:58 GMT Subject: [PATCH 5/5] index-pack: correct "offset" type in unpack_entry_data() Message-ID: <20160705170558.10906-6-pclouds@gmail.com> In-Reply-To: <20160705170558.10906-1-pclouds@gmail.com> unpack_entry_data() receives an off_t value from unpack_raw_entry(), which could be larger than unsigned long on 32-bit systems with large file support. Correct the type so truncation does not happen. This only affects bad object reporting though. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/index-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/index-pack.c b/builtin/index-pack.c index 73f7cd2..f35a9dc 100644 --- a/builtin/index-pack.c +++ b/builtin/index-pack.c @@ -430,7 +430,7 @@ static int is_delta_type(enum object_type type) return (type == OBJ_REF_DELTA || type == OBJ_OFS_DELTA); } -static void *unpack_entry_data(unsigned long offset, unsigned long size, +static void *unpack_entry_data(off_t offset, unsigned long size, enum object_type type, unsigned char *sha1) { static char fixed_buf[8192]; -- 2.8.2.537.g0965dd9