From: Jeff King <peff@peff.net>
Date: Fri, 01 Jul 2016 07:14:10 GMT
Subject: Re: [PATCH 1/4] push options: {pre,post}-receive hook learns about push options
Message-ID: <20160701071410.GG5358@sigill.intra.peff.net>
In-Reply-To: <20160630005951.7408-2-sbeller@google.com>

On Wed, Jun 29, 2016 at 05:59:48PM -0700, Stefan Beller wrote:

> The environment variable GIT_PUSH_OPTION_FILE is set to the push options
> separated by new line.
> 
> The code is not executed as the push options are set to NULL, nor is the
> new capability advertised.
> 
> The rationale for keeping the actual options inside a file instead of
> putting them directly into an environment variable has multiple reasons:

Thanks for including this rationale; my first thought on seeing the
patch was "wouldn't this be much more convenient for a hook if each
value had its own environment variable?".

Putting the data into a file does alleviate some issues. But it also
makes parsing annoying, and opens up new issues (like what happens
to content that has a newline in it?). Wouldn't multiple files be a bit
more convenient? Especially for your example of eventually carrying
larger binary content like images.

-Peff