From: Jeff King <peff@peff.net>
Date: Sun, 26 Jun 2016 23:51:29 GMT
Subject: Re: [PATCH 1/2] xread: retry after poll on EAGAIN/EWOULDBLOCK
Message-ID: <20160626235129.GC21668@sigill.intra.peff.net>
In-Reply-To: <20160626232112.721-2-e@80x24.org>

On Sun, Jun 26, 2016 at 11:21:11PM +0000, Eric Wong wrote:

> We should continue to loop after EAGAIN/EWOULDBLOCK as the
> intent of xread is to read as much as possible until an
> EOF or real error occurs.

BTW, a minor nit here. xread() does _not_ read as much as possible until
EOF. It tries until it gets a real error or at least one byte.

I know you inherited this mistaken text from 1079c4be0b, but we should
probably not repeat it.

-Peff