From: Charles Bailey <charles@hashpling.org>
Date: Thu, 16 Jun 2016 09:47:49 GMT
Subject: Re: [PATCH] grep: fix grepping for "intent to add" files
Message-ID: <20160616094749.GA20681@hashpling.org>
In-Reply-To: <20160616074709.GA24412@duynguyen-vnpc.vn.dektech.internal>

On Thu, Jun 16, 2016 at 02:47:09PM +0700, Duy Nguyen wrote:
> I don't think revert is right. It rather needs a re-fix like below.
> Basically we want grep_file() to run as normal, but grep_sha1()
> (i.e. git grep --cached) should ignore i-t-a entries, because empty
> SHA-1 is not the right content to grep. It does not matter in positive
> matching, sure, but it may in -v cache.

You don't think the revert is correct or you don't think the revert is
sufficient? (I wasn't able to find a test case which proved that the
change to line 399 was necessary, so perhaps I don't understand.)

I would have thought that grepping the empty SHA-1 would be correct for
with or without -v. An "intent to add" file has no content in the index
so I would expect it to have zero matching and zero non-matching lines
for any grep --cached query?

Or is this an efficiency and not a correctness concern?

Charles.