From: Elia Pinto Date: Fri, 03 Jun 2016 07:47:17 GMT Subject: [PATCH 03/10] builtin/tag.c: convert trivial snprintf calls to xsnprintf Message-ID: <20160603074724.12173-3-gitter.spiros@gmail.com> In-Reply-To: <20160603074724.12173-1-gitter.spiros@gmail.com> With the commits f2f02675 and 5096d490 we have been converted in some files the call from snprintf/sprintf/strcpy to xsnprintf. This patch converts the remaining calls to snprintf with xsnprintf under the following conditions: - The call to snprintf does not control the outcome of the command or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto --- builtin/tag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/tag.c b/builtin/tag.c index 50e4ae5..0345ca3 100644 --- a/builtin/tag.c +++ b/builtin/tag.c @@ -225,7 +225,7 @@ static void create_tag(const unsigned char *object, const char *tag, if (type <= OBJ_NONE) die(_("bad object type.")); - header_len = snprintf(header_buf, sizeof(header_buf), + header_len = xsnprintf(header_buf, sizeof(header_buf), "object %s\n" "type %s\n" "tag %s\n" -- 2.9.0.rc1.265.geb5d750