From: Eric Wong Date: Thu, 02 Jun 2016 21:13:46 GMT Subject: Re: [PATCH/RFC 0/4] Add option to enable filters in git-svn Message-ID: <20160602211346.GA24915@dcvr.yhbt.net> In-Reply-To: Matteo Bertini wrote: > Il 2016-05-31 20:12 Eric Wong ha scritto: > >Matteo Bertini wrote: > >>Sorry to all, but I missed a Checksum mismatch error, I'll have a > >>look and submit an update. > > I've had a look, the problem is a missing smudge filter. > Unluckily the small svn revision range i was using was never updating > a filtered file. > > The code actually uses `cat-file --batch` to get the blobs, > but the stored blob is not what SVN::TxDelta::apply need. > What I need is the smudged blob, but cat-file does not supports it. > > I can modify cat-file with a new option to call > `convert_to_working_tree`, > and have the filters applied, for example --use-filters, that expects an > extra field, like $sha\t$path, in the stdin stream. > > I don't like a lot putting an high level feature in a low level command, > but --textconv seems very similar to this. > > Opinions or other suggestions? In the absense of other opinions or suggestions, I suggest you try it and see what others think :) I'm not that experienced at the C code of this project, but I can try to follow along as best as I can.