From: SZEDER Gábor Date: Wed, 01 Jun 2016 11:59:38 GMT Subject: Re: [PATCH v2 1/2] completion: create variable for untracked file modes Message-ID: <20160601135938.Horde.2Daxezldve72SBukDSPenPP@webmail.informatik.kit.edu> In-Reply-To: <1464773846.4315.0.camel@virtuell-zuhause.de> This subject would perhaps read better: completion: factor out untracked file modes into a variable Quoting Thomas Braun : > Signed-off-by: Thomas Braun > --- > contrib/completion/git-completion.bash | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/contrib/completion/git-completion.bash > b/contrib/completion/git-completion.bash > index 3402475..addea89 100644 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -1098,6 +1098,8 @@ _git_clone () > esac > } > > +__git_untracked_file_modes="all no normal" > + > _git_commit () > { > case "$prev" in > @@ -1119,7 +1121,7 @@ _git_commit () > return > ;; > --untracked-files=*) > - __gitcomp "all no normal" "" "${cur##--untracked-files=}" > + __gitcomp "$__git_untracked_file_modes" "" "${cur##--untracked-files=}" > return > ;; > --*)