From: Junio C Hamano Date: Wed, 11 May 2016 23:35:46 GMT Subject: [PATCH 2/2] am: plug FILE * leak in split_mail_conv() Message-ID: <20160511233546.13090-2-gitster@pobox.com> In-Reply-To: <20160511233546.13090-1-gitster@pobox.com> Signed-off-by: Junio C Hamano --- builtin/am.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/builtin/am.c b/builtin/am.c index f1a84c6..a373928 100644 --- a/builtin/am.c +++ b/builtin/am.c @@ -761,9 +761,11 @@ static int split_mail_conv(mail_conv_fn fn, struct am_state *state, mail = mkpath("%s/%0*d", state->dir, state->prec, i + 1); out = fopen(mail, "w"); - if (!out) + if (!out) { + fclose(in); return error(_("could not open '%s' for writing: %s"), mail, strerror(errno)); + } ret = fn(out, in, keep_cr); -- 2.8.2-679-g91c6421