From: Jeff King <peff@peff.net>
Date: Thu, 28 Apr 2016 13:40:47 GMT
Subject: Re: [RFC] How to pass Git config command line instructions to Submodule commands?
Message-ID: <20160428134047.GA25364@sigill.intra.peff.net>
In-Reply-To: <FF931AB2-2381-4DF9-AE28-CE30EEC5C352@gmail.com>

On Thu, Apr 28, 2016 at 02:05:20PM +0200, Lars Schneider wrote:

> I am no expert in the Submodule code but I think the cloning of
> the submodules is not yet guarded with sanitize_submodule_env [3].
> That means the submodule is cloned with the GIT_CONFIG_PARAMETERS
> of the super project. That might explain why t5550 passes as the 
> credential config is only used in that area.
> 
> The submodule checkout is guarded with sanitize_submodule_env
> and therefore my Git-LFS filter use case is affect.
> 
> Does this sound reasonable?

Yes, that's exactly what's going on. git-submodule.sh's code _is_
broken, which is what you're seeing. I've just posted a series to fix
this. I think it would be reasonable to add filter.* to the whitelist on
top of that series.

-Peff