From: Michael S. Tsirkin Date: Thu, 07 Apr 2016 17:52:53 GMT Subject: Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t Message-ID: <20160407205144-mutt-send-email-mst@redhat.com> In-Reply-To: On Thu, Apr 07, 2016 at 10:30:02AM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Apr 07, 2016 at 09:55:29AM -0700, Junio C Hamano wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > Allow -t as a short-cut for --trailer. > >> > > >> > Signed-off-by: Michael S. Tsirkin > >> > --- > >> > >> As I do not think interpret-trailers is meant to be end-user facing, > >> I am not sure I should be interested in this step. > >> > >> I am in principle OK with the later step that teaches a single > >> letter option to end-user facing "git am" that would be turned into > >> "--trailer" when it calls out to "interpret-trailers" (I haven't > >> checked if 't' is a sensible choice for that single letter option, > >> though). > > > > Does OPT_PASSTHRU_ARGV handle this transformation for me? > > As I wrote in my response to Matthieu, PASSTHRU_ARGV is one thing I > specifically do not want to see used in this codepath. It sounds like a general kind of thing, does it not? Aren't there other cases where a short option needs to be converted to a long one? -- MST