From: Jeff King <peff@peff.net>
Date: Wed, 06 Apr 2016 06:16:50 GMT
Subject: Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable
Message-ID: <20160406061650.GA18208@sigill.intra.peff.net>
In-Reply-To: <CAPig+cSR6CQ6Q=TOaTgqwC0nOkB_khDLevWDPZsOwKbGrjptKQ@mail.gmail.com>

On Wed, Apr 06, 2016 at 01:53:35AM -0400, Eric Sunshine wrote:

> On Tue, Apr 5, 2016 at 6:21 AM, Elia Pinto <gitter.spiros@gmail.com> wrote:
> > 2016-04-01 22:25 GMT+02:00 Eric Sunshine <sunshine@sunshineco.com>:
> >> In addition to review comments by others, why are the new curl_dump()
> >> and curl_trace() functions duplicated in both patches rather than
> >> factored out to a shared implementation?
> >
> > It's right. Do you think i can use some existing file or should I
> > create a new object file ?
> 
> Peff or Junio would be more qualified to answer, but perhaps the
> shared implementation could go in http.c?

Yeah. If it is linking with curl it must be in one of the objects that
gets compiled only when NO_CURL is not set. Which is currently http.c,
http-walker.c, and remote-curl.c. Of the three, the only one that makes
sense is http.c.

A new file would be OK (provided it gets added to the OBJECTS line in
Makefile:1921) but I think it fits well in http.c, which is essentially
our bucket of curl-related wrappers.

-Peff