From: Jeff King <peff@peff.net>
Date: Tue, 05 Apr 2016 01:52:34 GMT
Subject: Re: [PATCH v5 4/4] pretty: test --expand-tabs
Message-ID: <20160405015234.GB29953@sigill.intra.peff.net>
In-Reply-To: <1459817917-32078-5-git-send-email-gitster@pobox.com>

On Mon, Apr 04, 2016 at 05:58:37PM -0700, Junio C Hamano wrote:

> +count_expand ()
> +{

This function takes a lot of unnamed arguments that we process with
"shift". It might be nice to give a brief comment describing them.

> +test_expand ""
> +test_expand --pretty
> +test_expand --pretty=short
> +test_expand --pretty=medium
> +test_expand --pretty=full
> +test_expand --pretty=fuller
> +test_expand --pretty=fuller
> +test_expand --pretty=raw
> +test_expand --pretty=email

Duplicated fuller?

-Peff