From: Jeff King <peff@peff.net>
Date: Thu, 31 Mar 2016 01:06:04 GMT
Subject: Re: [PATCHv2 1/4] notes: don't leak memory in git_config_get_notes_strategy
Message-ID: <20160331010604.GA23999@sigill.intra.peff.net>
In-Reply-To: <xmqqegarsmil.fsf@gitster.mtv.corp.google.com>

On Wed, Mar 30, 2016 at 02:07:14PM -0700, Junio C Hamano wrote:

> This is a tangent, but am I the only one who finds that the naming
> of functions in config-get API is confusing?  Just wondering if we
> should rename the ones that keeps the memory ownership to the config
> subsystem with s/get/peek/ or something.

You are definitely not the only one.

I think the get/peek thing would help, but I also get confused between
git_config_string() and git_config_get_string().

-Peff