From: Jeff King <peff@peff.net>
Date: Fri, 25 Mar 2016 17:59:47 GMT
Subject: Re: [PATCH v3/GSoC 2/5] path.c: implement xdg_runtime_dir()
Message-ID: <20160325175947.GC10563@sigill.intra.peff.net>
In-Reply-To: <CAKqreux8FHdJoKDishjQkbi9g1oUc265EUK4nOJ_sgeFivGSNA@mail.gmail.com>

On Fri, Mar 25, 2016 at 10:21:48PM +0800, 惠轶群 wrote:

> > There are some minor English problems here (and elsewhere). E.g., you
> > probably want "So we just issue a warning and leave it to the user to
> > solve.".
> 
> Sorry for my English.

Thanks. And sorry if that sounded too harsh. I know that working in a
non-native language is tough. Usually in a review I'll try to provide
specific English fixes, but in this case, I think a lot of these
messages are still in flux, so I I didn't want to waste either of our
time going over specifics if the content is just going to change later.

> > These ones leak, too.
> 
> I will deal with it.
> 
> I find there are some similar leakage in this file. I'll fix them in
> another patch.

Great, thanks.

-Peff