From: Jeff King <peff@peff.net>
Date: Fri, 25 Mar 2016 10:00:42 GMT
Subject: Re: [PATCH v3/GSoC 3/5] git-credential-cache: put socket to xdg-compatible path
Message-ID: <20160325100041.GC8880@sigill.intra.peff.net>
In-Reply-To: <1458728005-22555-3-git-send-email-huiyiqun@gmail.com>

On Wed, Mar 23, 2016 at 06:13:23PM +0800, Hui Yiqun wrote:

> move .git-credential-cache/socket to xdg_runtime_dir("credential-cache.sock")

Motivation?

> diff --git a/credential-cache.c b/credential-cache.c
> index f4afdc6..40d838b 100644
> --- a/credential-cache.c
> +++ b/credential-cache.c
> @@ -105,7 +105,7 @@ int main(int argc, const char **argv)
>  	op = argv[0];
>  
>  	if (!socket_path)
> -		socket_path = expand_user_path("~/.git-credential-cache/socket");
> +		socket_path = xdg_runtime_dir("credential-cache.sock");
>  	if (!socket_path)
>  		die("unable to find a suitable socket path; use --socket");

We do our own mkdir and chmod in credential-cache; this should be
redundant with what xdg_runtime_dir() does, and can be removed, right?

-Peff