From: Jeff King <peff@peff.net>
Date: Fri, 18 Mar 2016 05:01:24 GMT
Subject: Re: [PATCH v2/GSoC 4/4] t0301: test credential-cache support of XDG_RUNTIME_DIR
Message-ID: <20160318050124.GB22327@sigill.intra.peff.net>
In-Reply-To: <CAKqreuy0jU7WOi8_iGXR2hzYJE0kG8855hQuaeaW9OTKm3yF_Q@mail.gmail.com>

On Fri, Mar 18, 2016 at 12:38:16PM +0800, 惠轶群 wrote:

> >> +test_expect_success 'when $XDG_RUNTIME_DIR is set, `$XDG_RUNTIME_DIR/git` are used' '
> >> +     test_path_is_missing "/tmp/git-$(id -u)/git/credential-cache.sock" &&
> >> +     test -S "$HOME/xdg_runtime/git/credential-cache.sock"
> >> +'
> >
> > This test fails for me, probably because XDG_RUNTIME_DIR is not
> > exported.
> >
> > -Peff
> 
> Could you please give a try to the patch set v2, test of which is
> definitely passed on my computer.

Yes, that was what I tried earlier (and I just re-tested to make sure).
It still fails. I suspect it has to do with whether XDG_RUNTIME_DIR is
set in our environments (outside of the test suite). If I run:

  XDG_RUNTIME_DIR=/tmp/foo ./t0301-credential-cache.sh

it passes.

-Peff