From: Jeff King <peff@peff.net>
Date: Tue, 15 Mar 2016 21:55:24 GMT
Subject: Re: [PATCH v2] submodule-config: use hashmap_iter_first()
Message-ID: <20160315215524.GB30011@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kZ_wbJ2MGs_E-P_0eLk3JX_0QhT1c_BxqWCS+vrg8+xwA@mail.gmail.com>

On Tue, Mar 15, 2016 at 12:21:36PM -0700, Stefan Beller wrote:

> On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov
> <kuleshovmail@gmail.com> wrote:
> > from the <hashmap.h> for simplification.
> 
> I think what Eric wanted to point out, was to not have a continuous sentence
> from commit message header to body.
> 
> Either leave the body blank (as it is obvious) or write a whole sentence there:
> 
>   [PATCH v2] submodule-config: use hashmap_iter_first()
> 
>   The hashmap API offers the `hashmap_iter_first` function as initializing and
>   getting the first entry is a common pattern. Use that instead of
> doing initialization
>   by hand and then get the first entry.

While we are nitpicking...:)

As a reader (either reviewing now, or looking at the change later in
git-log), I think my biggest question is: why?  Do we expect this to
change behavior, or is this just a cleanup? There's nothing wrong with
"just" a cleanup, but knowing that is the intent is helpful.

-Peff