From: Jeff King <peff@peff.net>
Date: Tue, 01 Mar 2016 15:05:43 GMT
Subject: Re: [PATCH] environment.c: introduce DECLARE_GIT_GETTER helper macro
Message-ID: <20160301150543.GN12887@sigill.intra.peff.net>
In-Reply-To: <1456601744-18404-1-git-send-email-kuleshovmail@gmail.com>

On Sun, Feb 28, 2016 at 01:35:44AM +0600, Alexander Kuleshov wrote:

> +DECLARE_GIT_GETTER(const char *, get_git_dir, git_dir)
> +DECLARE_GIT_GETTER(const char *, get_git_namespace, namespace)
> +DECLARE_GIT_GETTER(char *, get_object_directory, git_object_dir)
> +DECLARE_GIT_GETTER(char *, get_index_file, git_index_file)
> +DECLARE_GIT_GETTER(char *, get_graft_file, git_graft_file)

Hmm. I'm somewhat lukewarm on this patch. It's fewer lines and less
duplication, which is nice, but this kind of code generation often makes
things annoying (to step into with the debugger, to find with ctags,
etc). I dunno.

-Peff