From: Jeff King <peff@peff.net>
Date: Mon, 29 Feb 2016 22:13:15 GMT
Subject: Re: [PATCH v6 28/32] config: read ref storage config on startup
Message-ID: <20160229221315.GF25342@sigill.intra.peff.net>
In-Reply-To: <1456783069.18017.66.camel@twopensource.com>

On Mon, Feb 29, 2016 at 04:57:49PM -0500, David Turner wrote:

> > By the way, I notice that the default value for the_refs_backend is
> > "&refs_be_files". It might be safer to make this NULL (or some
> > &refs_be_null that fills the vtable, but just returns an error for
> > each
> > call).
> 
> In 'refs: register ref storage backends', I do make this change.  I
> don't do it earlier because we don't have this config stuff in place
> yet.

Ah, OK. I was that we did register the files backend as a normal one,
but I missed the assignment to NULL (I do wonder if we want a
refs_be_null to smoke out problem cases with a die("BUG") rather than
segfaulting, but in theory nobody should be doing that).

-Peff