From: Jeff King Date: Wed, 24 Feb 2016 10:27:29 GMT Subject: Re: [PATCH 1/5] Documentation/diff-config: fix description of diff.renames Message-ID: <20160224102729.GC21152@sigill.intra.peff.net> In-Reply-To: <1456249498-3232-2-git-send-email-Matthieu.Moy@imag.fr> On Tue, Feb 23, 2016 at 06:44:54PM +0100, Matthieu Moy wrote: > The description was misleading, since "set to any boolean value" include > "set to false", and diff.renames=false does not enable basic detection, > but actually disables it. > > Signed-off-by: Matthieu Moy > --- > Documentation/diff-config.txt | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/diff-config.txt b/Documentation/diff-config.txt > index 6eaa452..1acd203 100644 > --- a/Documentation/diff-config.txt > +++ b/Documentation/diff-config.txt > @@ -108,9 +108,10 @@ diff.renameLimit:: > detection; equivalent to the 'git diff' option '-l'. > > diff.renames:: > - Tells Git to detect renames. If set to any boolean value, it > - will enable basic rename detection. If set to "copies" or > - "copy", it will detect copies, as well. > + Whether and how Git detects renames. If set to "false", > + rename detection is disabled. If set to "true", basic rename > + detection is enable. If set to "copies" or "copy", Git will > + detect copies, as well. Defaults to false. Looks OK to me. I thought we had "copies-harder" or something, but I double-checked and we don't. I doubt anybody would want to set it anyway, as it can be quite expensive. -Peff