From: Jeff King <peff@peff.net>
Date: Wed, 24 Feb 2016 10:25:10 GMT
Subject: Re: [PATCH 2/5] t4001-diff-rename: wrap file creations in a test
Message-ID: <20160224102510.GB21152@sigill.intra.peff.net>
In-Reply-To: <1456249498-3232-3-git-send-email-Matthieu.Moy@imag.fr>

On Tue, Feb 23, 2016 at 06:44:55PM +0100, Matthieu Moy wrote:

> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---
>  t/t4001-diff-rename.sh | 38 +++++++++++++++++++++-----------------
>  1 file changed, 21 insertions(+), 17 deletions(-)
> 
> diff --git a/t/t4001-diff-rename.sh b/t/t4001-diff-rename.sh
> index 2f327b7..bfb364c 100755
> --- a/t/t4001-diff-rename.sh
> +++ b/t/t4001-diff-rename.sh
> @@ -9,7 +9,9 @@ test_description='Test rename detection in diff engine.
>  . ./test-lib.sh
>  . "$TEST_DIRECTORY"/diff-lib.sh
>  
> -echo >path0 'Line 1
> +test_expect_success 'setup' '
> +	cat >path0 <<\EOF &&
> +Line 1
>  Line 2
>  Line 3
>  Line 4

Should we use "<<-" here (and elsewhere) to indent the sample lines? It
makes your diff bigger, but I think the end result is much easier to
read.

-Peff