From: Jeff King <peff@peff.net>
Date: Fri, 19 Feb 2016 12:03:11 GMT
Subject: Re: [PATCHv13 5/7] git submodule update: have a dedicated helper for cloning
Message-ID: <20160219120310.GB10204@sigill.intra.peff.net>
In-Reply-To: <1455838398-12379-6-git-send-email-sbeller@google.com>

On Thu, Feb 18, 2016 at 03:33:16PM -0800, Stefan Beller wrote:

> +	if (needs_cloning) {
> +		cp->git_cmd = 1;
> +		cp->no_stdin = 1;
> +		cp->stdout_to_stderr = 1;
> +		cp->err = -1;
> +		argv_array_push(&cp->args, "submodule--helper");
> +		argv_array_push(&cp->args, "clone");
> +		if (pp->quiet)
> +			argv_array_push(&cp->args, "--quiet");
> +
> +		if (pp->prefix)
> +			argv_array_pushl(&cp->args, "--prefix", pp->prefix, NULL);
> +
> +		argv_array_pushl(&cp->args, "--path", sub->path, NULL);
> +		argv_array_pushl(&cp->args, "--name", sub->name, NULL);
> +		argv_array_pushl(&cp->args, "--url", strdup(url), NULL);

No need to strdup() here; argv_array handles its own memory, so this
just leaks (and if we were keeping it, it should be xstrdup(), of
course).

-Peff