From: Jeff King <peff@peff.net>
Date: Wed, 17 Feb 2016 19:19:24 GMT
Subject: Re: [PATCH v2 0/3] fix "v"iew subcommand in "git am -i"
Message-ID: <20160217191923.GA16265@sigill.intra.peff.net>
In-Reply-To: <1455736516-13466-1-git-send-email-gitster@pobox.com>

On Wed, Feb 17, 2016 at 11:15:13AM -0800, Junio C Hamano wrote:

> So the first patch in this series factors out a helper function to
> let the caller run the pager the right way.  They make the third
> patch to fix the breakage in "am" trivial.  Compared to v1, the
> helper was much simplified with help by Peff: it always and only
> takes child-process and the pager command string.  The caller can
> append extra command line arguments after the helper returns if it
> wants to.
> 
> Junio C Hamano (3):
>   pager: lose a separate argv[]
>   pager: factor out a helper to prepare a child process to run the pager
>   am -i: fix "v"iew
> 
>  builtin/am.c |  2 +-
>  cache.h      |  3 +++
>  pager.c      | 19 +++++++++++--------
>  3 files changed, 15 insertions(+), 9 deletions(-)

The whole thing looks good to me.

-Peff