From: Jeff King <peff@peff.net>
Date: Tue, 16 Feb 2016 17:38:54 GMT
Subject: Re: [PATCH v4 3/3] config: add '--show-origin' option to print the origin of a config value
Message-ID: <20160216173853.GA15026@sigill.intra.peff.net>
In-Reply-To: <56C3524F.3000504@ramsayjones.plus.com>

On Tue, Feb 16, 2016 at 04:46:07PM +0000, Ramsay Jones wrote:

> > OK, I am happy to add the extra code. 
> 
> Unless I've missed something (quite possible), this patch does not
> need to change. (you have (both) convinced me that your current
> solution is the best).
> 
> The only change that I would suggest is the one-liner I already
> suggested to the previous patch (plus the one-liner in the test,
> of course. err ... so the two-liner!). Having said that, I didn't
> try it out - I was just typing into my email client, so ...

I think it's more than that one-liner. This patch shows "type:name"
verbatim from what is passed into do_config_from_file, as does the error
message. If they are going to have different output formats (e.g.,
"<stdin>" versus "stdin"), there needs to be logic transforming them in
at least one of the spots.

-Peff